Repository navigation
Test skipRemove once at the end of unmount() - #5381
Merged
Merged
Conversation
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. duration
usedJSHeapSize
Results⏳ Benchmarks are currently running. Results below are out of date. create10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -2 B (-0.01%) Total Size: 16.3 kB 📦 View Changed
ℹ️ View Unchanged
|
JoviDeCroock
enabled auto-merge
November 18, 2026 09:50
marvinhagemeister
approved these changes
Nov 18, 2026
JoviDeCroock
force-pushed
the
golf/unmount-skip-remove
branch
3 times, most recently
from
November 18, 2026 10:26
dfc87e4 to
d5555b6
Compare
Both trailing statements were guarded by !skipRemove.
JoviDeCroock
force-pushed
the
golf/unmount-skip-remove
branch
from
November 18, 2026 10:30
d5555b6 to
7f02406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both trailing statements in
unmount()were guarded by!skipRemove; they now share one check.Saves 2 B gzip in core.
Note
Written with the help of Fable 5.2