Skip to content

Test skipRemove once at the end of unmount() - #5381

Merged
JoviDeCroock merged 1 commit into
mainfrom
golf/unmount-skip-remove
Nov 18, 2026
Merged

JoviDeCroock merged 1 commit into
mainfrom
golf/unmount-skip-remove

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Both trailing statements in unmount() were guarded by !skipRemove; they now share one check.

Saves 2 B gzip in core.

Note

Written with the help of Fable 5.2

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +0% (-6.60ms - +1.67ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.08ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +0% (-0.72ms - +0.15ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.04ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -4% - +8% (-2.43ms - +5.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -4% - +2% (-0.70ms - +0.31ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +3% (-1.40ms - +0.98ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +1% (-0.33ms - +0.04ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +2% (-0.03ms - +0.02ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local553.11ms - 558.17ms-unsure 🔍
-1% - +0%
-6.60ms - +1.67ms
preact-main554.84ms - 561.38msunsure 🔍
-0% - +1%
-1.67ms - +6.60ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.24ms - 19.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.24ms - 19.24msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.64ms-unsure 🔍
-0% - +0%
-0.01ms - +0.08ms
preact-main16.54ms - 16.61msunsure 🔍
-0% - +0%
-0.08ms - +0.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main1.56ms - 1.57msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
hydrate1k
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #6226
  • Commit: 32335c2

duration

VersionAvg timevs preact-localvs preact-main
preact-local37.00ms - 37.72ms-unsure 🔍
-2% - +0%
-0.72ms - +0.15ms
preact-main37.41ms - 37.90msunsure 🔍
-0% - +2%
-0.15ms - +0.72ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.07ms - 5.25ms-unsure 🔍
-6% - +1%
-0.33ms - +0.04ms
preact-main5.15ms - 5.46msunsure 🔍
-1% - +6%
-0.04ms - +0.33ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.61ms-unsure 🔍
-0% - +0%
-0.04ms - +0.03ms
preact-main16.56ms - 16.60msunsure 🔍
-0% - +0%
-0.03ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #6226
  • Commit: 32335c2

duration

VersionAvg timevs preact-localvs preact-main
preact-local58.38ms - 63.60ms-unsure 🔍
-4% - +8%
-2.43ms - +5.03ms
preact-main57.02ms - 62.35msunsure 🔍
-8% - +4%
-5.03ms - +2.43ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.04ms - 3.04ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.04ms - 3.05msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local20.51ms - 21.27ms-unsure 🔍
-3% - +2%
-0.63ms - +0.33ms
preact-main20.75ms - 21.33msunsure 🔍
-2% - +3%
-0.33ms - +0.63ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local24.91ms - 25.73ms-unsure 🔍
-3% - +1%
-0.75ms - +0.37ms
preact-main25.13ms - 25.89msunsure 🔍
-1% - +3%
-0.37ms - +0.75ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.01ms - 26.79ms-unsure 🔍
-1% - +3%
-0.28ms - +0.84ms
preact-main25.72ms - 26.51msunsure 🔍
-3% - +1%
-0.84ms - +0.28ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 27.44ms-unsure 🔍
-3% - +2%
-0.70ms - +0.49ms
preact-main26.71ms - 27.69msunsure 🔍
-2% - +3%
-0.49ms - +0.70ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.24ms - 21.70ms-unsure 🔍
-2% - +2%
-0.48ms - +0.52ms
preact-main21.01ms - 21.90msunsure 🔍
-2% - +2%
-0.52ms - +0.48ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.29ms - 21.68ms-unsure 🔍
-4% - +6%
-0.88ms - +1.14ms
preact-main20.11ms - 21.59msunsure 🔍
-5% - +4%
-1.14ms - +0.88ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #6226
  • Commit: 32335c2

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.81ms - 1.92ms-unsure 🔍
-5% - +4%
-0.10ms - +0.07ms
preact-main1.82ms - 1.95msunsure 🔍
-4% - +6%
-0.07ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.04ms-unsure 🔍
-3% - +2%
-0.03ms - +0.02ms
preact-main1.01ms - 1.04msunsure 🔍
-2% - +3%
-0.02ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.21ms - 15.78ms-unsure 🔍
-4% - +2%
-0.70ms - +0.31ms
preact-main15.28ms - 16.11msunsure 🔍
-2% - +5%
-0.31ms - +0.70ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
update10th1k
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #6226
  • Commit: 32335c2

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.44ms - 29.27ms-unsure 🔍
-5% - +3%
-1.40ms - +0.98ms
preact-main27.80ms - 29.32msunsure 🔍
-3% - +5%
-0.98ms - +1.40ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 3.00ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.99ms - 3.00msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Size Change: -2 B (-0.01%)

Total Size: 16.3 kB

📦 View Changed
Filename Size Change
dist/preact.mjs 4.96 kB -2 B (-0.04%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.97 kB
debug/dist/debug.mjs 4.19 kB
devtools/dist/devtools.mjs 268 B
hooks/dist/hooks.mjs 1.52 kB
jsx-runtime/dist/jsxRuntime.mjs 875 B
test-utils/dist/testUtils.mjs 472 B

compressed-size-action

@coveralls

coveralls commented Nov 18, 2026 •

Copy link
Copy Markdown

Coverage Status

No base build to compare — golf/unmount-skip-remove into main

@JoviDeCroock
JoviDeCroock force-pushed the golf/unmount-skip-remove branch 3 times, most recently from dfc87e4 to d5555b6 Compare November 18, 2026 10:26
Both trailing statements were guarded by !skipRemove.
@JoviDeCroock
JoviDeCroock force-pushed the golf/unmount-skip-remove branch from d5555b6 to 7f02406 Compare November 18, 2026 10:30
@JoviDeCroock
JoviDeCroock merged commit 39b6821 into main Nov 18, 2026
4 checks passed
@JoviDeCroock
JoviDeCroock deleted the golf/unmount-skip-remove branch November 18, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants